Rewrite extension, call API manually, take advantage of features not supported by the current library #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaucau
changed the title
askvortsov1
requested changes
Dec 28, 2021
Co-authored-by: Alexander Skvortsov <[email protected]>
Co-Authored-By: Alexander Skvortsov <[email protected]>
askvortsov1
requested changes
Jan 1, 2022
Co-authored-by: Alexander Skvortsov <[email protected]>
askvortsov1
requested changes
Jan 1, 2022
askvortsov1
approved these changes
Jan 1, 2022
SychO9
approved these changes
Jan 4, 2022
|
Confirmed to work locally. Thanks again so much for this! |
|
Thank you @rafaucau for dealing with this ! 🙏🏻 |
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
…supported by the current library (#24) This PR updates the entire extension. It will not use a library that has not been updated for years, so it should work with newer versions of PHP. Additionally, it sends more information to the Akismet API to make spam detection more accurate. The Akismet class can be used by other extensions. Todo: - [x] Convert frontend to TypeScript - [x] Call Akismet API manually - [x] Option to remove blatant spam - [x] Permission to bypass Akismet - [x] Sending additional parameters like `is_test` Nice to have, but can be left for another PR: - [ ] Suspend obvious spamers - [ ] Send `blog_lang` parameter - [ ] Checking post edits Sponsored by [forum.android.com.pl](https://forum.android.com.pl/)
askvortsov1
pushed a commit
that referenced
this pull request
May 10, 2022
…supported by the current library (#24) This PR updates the entire extension. It will not use a library that has not been updated for years, so it should work with newer versions of PHP. Additionally, it sends more information to the Akismet API to make spam detection more accurate. The Akismet class can be used by other extensions. Todo: - [x] Convert frontend to TypeScript - [x] Call Akismet API manually - [x] Option to remove blatant spam - [x] Permission to bypass Akismet - [x] Sending additional parameters like `is_test` Nice to have, but can be left for another PR: - [ ] Suspend obvious spamers - [ ] Send `blog_lang` parameter - [ ] Checking post edits Sponsored by [forum.android.com.pl](https://forum.android.com.pl/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2405
Changes proposed in this pull request:
This PR updates the entire extension. It will not use a library that has not been updated for years, so it should work with newer versions of PHP.
Additionally, it sends more information to the Akismet API to make spam detection more accurate.
The Akismet class can be used by other extensions.
Todo:
is_testNice to have, but can be left for another PR:
blog_langparameterSponsored by forum.android.com.pl
Reviewers should focus on:
Everything
Necessity
Confirmed
composer test).