-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite extension, call API manually, take advantage of features not supported by the current library #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your hard work on this! Left some review comments below.
Co-authored-by: Alexander Skvortsov <[email protected]>
Co-Authored-By: Alexander Skvortsov <[email protected]>
Co-authored-by: Alexander Skvortsov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
witParams
should be withParams
, but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, haven't tested it locally though.
Just a minor comment.
Confirmed to work locally. Thanks again so much for this! |
Thank you @rafaucau for dealing with this ! 🙏🏻 |
…supported by the current library (#24) This PR updates the entire extension. It will not use a library that has not been updated for years, so it should work with newer versions of PHP. Additionally, it sends more information to the Akismet API to make spam detection more accurate. The Akismet class can be used by other extensions. Todo: - [x] Convert frontend to TypeScript - [x] Call Akismet API manually - [x] Option to remove blatant spam - [x] Permission to bypass Akismet - [x] Sending additional parameters like `is_test` Nice to have, but can be left for another PR: - [ ] Suspend obvious spamers - [ ] Send `blog_lang` parameter - [ ] Checking post edits Sponsored by [forum.android.com.pl](https://forum.android.com.pl/)
…supported by the current library (#24) This PR updates the entire extension. It will not use a library that has not been updated for years, so it should work with newer versions of PHP. Additionally, it sends more information to the Akismet API to make spam detection more accurate. The Akismet class can be used by other extensions. Todo: - [x] Convert frontend to TypeScript - [x] Call Akismet API manually - [x] Option to remove blatant spam - [x] Permission to bypass Akismet - [x] Sending additional parameters like `is_test` Nice to have, but can be left for another PR: - [ ] Suspend obvious spamers - [ ] Send `blog_lang` parameter - [ ] Checking post edits Sponsored by [forum.android.com.pl](https://forum.android.com.pl/)
Resolves #2405
Changes proposed in this pull request:
This PR updates the entire extension. It will not use a library that has not been updated for years, so it should work with newer versions of PHP.
Additionally, it sends more information to the Akismet API to make spam detection more accurate.
The Akismet class can be used by other extensions.
Todo:
is_test
Nice to have, but can be left for another PR:
blog_lang
parameterSponsored by forum.android.com.pl
Reviewers should focus on:
Everything
Necessity
Confirmed
composer test
).