Pass null/falsy values through Model.getIdentifier #3131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2876
Changes proposed in this pull request:
model
inModel.getIdentifier
if falsyReviewers should focus on:
null
or all falsy values?null
, so that we don't modify the data (would add confusion)model.data
?if
statement instead to make the code clearer?getIdentifier
method?Screenshots
![image](https://user-images.githubusercontent.com/6401250/139100626-37f9247a-f4be-4807-abb6-3fdf3448818b.png)
Before
After
![image](https://user-images.githubusercontent.com/6401250/139100785-841828f0-2049-4d80-9f5d-00c92d812117.png)
Necessity
Confirmed
composer test
).