Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriptions): filter followed discussions when searching #3376

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

dsevillamartin
Copy link
Member

@dsevillamartin dsevillamartin commented Apr 3, 2022

Fixes #3375

Changes proposed in this pull request:

  • fix(subscriptions): filter followed discussions when searching in following page
  • added params.filter ||= {} cause i think we basically rely on tags for it? unsure, may not be needed

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@dsevillamartin dsevillamartin merged commit cd8ed6c into main Apr 3, 2022
@dsevillamartin dsevillamartin deleted the ds/3375-fix-search-in-following-page branch April 3, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subscriptions] Following page doesn't filter with a search query present
4 participants