-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: package manager failures not showing alerts #3647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense. Hopefully the request error handling system will show an error alert too? Not seeing that on the screenshot
@askvortsov1 the point is not showing error when validation failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, for the error though, it would be better to move calling the custom errorHandler
within catch
of every package manager request so that it can all fallback to the default error handler instead of having to reinvent the wheel. (should have done that when I built this but oh well..)
So basically, it's changing every instance of:
app.request({
method: ...,
...,
errorHandler,
})
to
app.request({
method: ...,
...,
}).catch(errorHandler)
and adapting the custom error handler if it needs any changes.
@SychO9 ah, I see, i have try on local |
the custom error handler is necessary for other type of errors which the default one doesn't understand 😇 |
Signed-off-by: Sami Mazouz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤗
LoadingModal
when install falied
LoadingModal
LoadingModal is not closed when the installation failsFixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test
).Required changes: