fix: package manager failures not showing alerts

[datlechin]

LoadingModal LoadingModal is not closed when the installation fails

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

• Has the problem that is being solved here been clearly explained?
• If applicable, have various options for solving this problem been considered?
• For core PRs, does this need to be in core, or could it be in an extension?
• Are we willing to maintain this for years / potentially forever?

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).
• Core developer confirmed locally this works as intended.
• Tests have been added, or are not appropriate here.

Required changes:

• Related documentation PR: (Remove if irrelevant)
• Related core extension PRs: (Remove if irrelevant)

[askvortsov1]

Change makes sense. Hopefully the request error handling system will show an error alert too? Not seeing that on the screenshot

[datlechin]

@askvortsov1 the point is not showing error when validation failed

[SychO9]

Good catch, for the error though, it would be better to move calling the custom errorHandler within catch of every package manager request so that it can all fallback to the default error handler instead of having to reinvent the wheel. (should have done that when I built this but oh well..)

So basically, it's changing every instance of:

app.request({
  method: ...,
  ...,
  errorHandler,
})

to

app.request({
  method: ...,
  ...,
}).catch(errorHandler)

and adapting the custom error handler if it needs any changes.

[datlechin]

@SychO9 ah, I see, i have try on local
so we no need to use errorHandler on request
it works well

[SychO9]

the custom error handler is necessary for other type of errors which the default one doesn't understand 😇

[SychO9]

Thanks 🤗