Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling mdarea via admin setting #27

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

askvortsov1
Copy link
Sponsor Member

@askvortsov1 askvortsov1 commented Mar 25, 2021

With the latest version of mdarea, we've had several reports of issues:

As a workaround so that markdown formatting is usable while we're waiting for this to be fixed upstream, this PR adds an admin setting that allows disabling mdarea.

@dsevillamartin
Copy link
Member

Why does the file need to be renamed? I know we don't export this stuff to compat so it doesn't matter that much, but I'd just like know.

Aside from that, code seems fine. Not tested locally.

@askvortsov1
Copy link
Sponsor Member Author

Why does the file need to be renamed? I know we don't export this stuff to compat so it doesn't matter that much, but I'd just like know.

Previously, it was named MarkdownAreaEditor. If mdarea isn't always going to be used, that name is misleading, so a more generic MarkdownEditor doesn't imply that mdarea will always be used.

Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- no issues at first glance.

(Though my review doesn't actually count for anything according to GitHub lol)

@askvortsov1 askvortsov1 merged commit 29fd332 into master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants