Editor Consolidation #28
Conversation
In the future, we could implement the features we use (list continue, indent) in core.
There was a problem hiding this comment.
Looks good, just that one idea. Can we wait for review comments on flarum/framework#2826 before merging though, as a fix for Win + Enter submitting could be used here to reduce complexity.
| view(vnode) { | ||
| return <div id="MarkdownToolbar" data-for={this.attrs.for} style={{ display: 'inline-block' }}> | ||
| return <div class="MarkdownToolbar"> |
There was a problem hiding this comment.
Is this change from id to class necessary? Are we intentionally breaking styles that use the ID here?
There was a problem hiding this comment.
I do agree with this change, just in case theres two of these toolbars on screen at the same time, despite how ridiculously unlikely that would be
There was a problem hiding this comment.
I also agree with this change, while in theory it shouldn't be needed it also makes a lot of sense.
There was a problem hiding this comment.
Iirc, there isn't ID based stuff anywhere else in the composer hierarchy. I don't think it should be here either.
- Move insertText to core - Move styles and apply to core - Simplify shortcut and button system - Drop mdarea for now. In the future, we could implement the features we use (list continue, indent) in core. - Remove admin dist (only admin setting was mdarea) - Move inline style to css
- Move insertText to core - Move styles and apply to core - Simplify shortcut and button system - Drop mdarea for now. In the future, we could implement the features we use (list continue, indent) in core. - Remove admin dist (only admin setting was mdarea) - Move inline style to css
Companion to flarum/framework#2826