Make markdown toolbar extensible

[davwheat]

Replaces #31 because I broke GitHub.

[askvortsov1]

respectable

[dsevillamartin]

Is this easily extendible? I thought using override/extend on exported functions was hard (cause don't you have to go through flarum.core.compat to be able to modify the method?)

Just occurred to me.

[davwheat]

This should work:

old = markdownToolbarItems;
markdownToolbarItems = function (){
  const items = old();

  items.add(/* ... */);

  return items;
}

[dsevillamartin]

@davwheat Um, don't think so? Assigning variables from import statements don't change what the import refers to afaik... That'd only work for a global variable or an exported object/class.

[askvortsov1]

This should work:

old = markdownToolbarItems;
markdownToolbarItems = function (){
  const items = old();

  items.add(/* ... */);

  return items;
}

Ah yeah David is right. Until we have an export registry and can actually replace functions in the registry, this won't work.

For some reason I thought this was being added a a method, must have missed this, sorry

[askvortsov1]

see above

[davwheat]

Hoping that #34 will be merged first, since this PR will need some changes once that is done.

[davwheat]

Ready for review now.

[askvortsov1]

Shouldn't we be able to override in either case?

[davwheat]

When I tried that, it seemed to error at runtime.

[davwheat]

This is because it calls bind on the original function, which doesn't exist.

[askvortsov1]

Hmm, we might want to change that in core. But makes sense for now.

[davwheat]

I agree