Skip to content

Commit

Permalink
fix: sort options not persisted after page reload (#35)
Browse files Browse the repository at this point in the history
* fix: sort options not persisted after page reload

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <[email protected]>
  • Loading branch information
imorland and StyleCIBot committed Jun 29, 2023
1 parent 61ffa3c commit 95f337e
Show file tree
Hide file tree
Showing 4 changed files with 102 additions and 2 deletions.
15 changes: 13 additions & 2 deletions extend.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@
* file that was distributed with this source code.
*/

namespace Flarumite\DiscussionViews;

use Flarum\Api\Controller;
use Flarum\Api\Serializer\DiscussionSerializer;
use Flarum\Database\AbstractModel;
use Flarum\Discussion\Event\Saving;
use Flarum\Discussion\Filter\DiscussionFilterer;
use Flarum\Discussion\Search\DiscussionSearcher;
use Flarum\Extend;
use Flarumite\DiscussionViews\AddAttributesBasedOnPermission;
use Flarumite\DiscussionViews\Listeners;

return [
(new Extend\Frontend('forum'))
Expand Down Expand Up @@ -44,4 +46,13 @@

(new Extend\Settings())
->default('fsdv.ignore-crawlers', true),

(new Extend\ServiceProvider())
->register(Provider\DiscussionViewsProvider::class),

(new Extend\SimpleFlarumSearch(DiscussionSearcher::class))
->addGambit(Search\PopularFilterGambit::class),

(new Extend\Filter(DiscussionFilterer::class))
->addFilter(Search\PopularFilterGambit::class),
];
1 change: 1 addition & 0 deletions src/Listeners/AddDiscussionViewHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class AddDiscussionViewHandler
* @var SettingsRepositoryInterface
*/
public $settings;

/**
* @var bool
*
Expand Down
27 changes: 27 additions & 0 deletions src/Provider/DiscussionViewsProvider.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?php

/*
* This file is part of flarumite/simple-discussion-views.
*
* Copyright (c) 2020 Flarumite.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Flarumite\DiscussionViews\Provider;

use Flarum\Foundation\AbstractServiceProvider;

class DiscussionViewsProvider extends AbstractServiceProvider
{
public function register()
{
$this->container->extend('flarum.forum.discussions.sortmap', function (array $map) {
return array_merge($map, [
'popular' => '-view_count',
'unpopular' => 'view_count',
]);
});
}
}
61 changes: 61 additions & 0 deletions src/Search/PopularFilterGambit.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?php

/*
* This file is part of flarumite/simple-discussion-views.
*
* Copyright (c) 2020 Flarumite.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Flarumite\DiscussionViews\Search;

use Flarum\Filter\FilterInterface;
use Flarum\Filter\FilterState;
use Flarum\Search\AbstractRegexGambit;
use Flarum\Search\SearchState;
use Flarum\User\User;
use Illuminate\Database\Query\Builder;

class PopularFilterGambit extends AbstractRegexGambit implements FilterInterface
{
/**
* {@inheritDoc}
*/
public function getFilterKey(): string
{
return 'popular';
}

/**
* {@inheritDoc}
*/
public function getGambitPattern()
{
return 'is:popular';
}

/**
* {@inheritDoc}
*/
public function filter(FilterState $filterState, string $filterValue, bool $negate)
{
$this->sort($filterState->getQuery(), $filterState->getActor(), $negate);
}

protected function sort(Builder $query, User $actor, bool $negate)
{
$query->orderBy('view_count', 'desc');
}

/**
* @param SearchState $search
* @param array $matches
* @param $negate
*/
protected function conditions(SearchState $search, array $matches, $negate)
{
$this->sort($search->getQuery(), $search->getActor(), $negate);
}
}

0 comments on commit 95f337e

Please sign in to comment.