Update yts_downloader.py #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On slower connections a 7 sec timeout is a very low threshold . I increased to 45. My 2020 MBP on 100/100 Mbps wifi was taking 25 seconds every time. Also yts.am html has changed. They wrapped the value you're trying to get in <b> tags. I updated line 23 to get the value needed. it was getting '<b>18' and then trying to convert that to int.
|
Thanks a lot for the PR. I'll need some time to approve the changes as I haven't touched the project in a year. I also need to check whether the package is working in the current condition or not. |
|
@flashblaze Actually the issue I was posted is the same that @Kallbrig talking about here (I mean the b tag stuff...) also another feature should be implemented (I talk about it in detail in the issue). |
SeifESlimene
reviewed
Sep 2, 2021
| except requests.Timeout: | ||
| print('Request timeout') | ||
| else: | ||
|
|
||
| soup = BeautifulSoup(r.text, 'html.parser') | ||
| h2 = soup.find_all('h2') | ||
| movie_count = int((str(h2)[5:11].replace(',', ''))) | ||
| movie_count = int((str(h2)[8:13].replace(',', ''))) |
There was a problem hiding this comment.
movie_count = int((str(h2)[8:14].replace(',', '')))
Be careful it's 8:14 not 8:13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On slower connections a 7 sec timeout is a very low threshold . I increased to 45. My 2020 MBP on 100/100 Mbps wifi was taking 25 seconds every time.
Also yts.am html has changed. They wrapped the value you're trying to get in bold tags. I updated line 23 to get the value needed. it was getting the first <b tag and the first 2 values of the number (<\b >18 ) and then trying to convert that to int.