Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility flag for ignoring missing target node in replace operation #102

Conversation

mbolgariw
Copy link
Contributor

No description provided.

@holograph
Copy link
Collaborator

LGTM, though maybe it’s worth documenting what happens when something is indeed missing

@mbolgariw
Copy link
Contributor Author

"replace" operation is equal to removing the previous value and then adding the new value.
in the previous versions of this lib it was possible to "replace" a value which didn't exist in the target json, now - the lib enforces that the node to replace must exist in the target json. for sake of backward compatibility this PR ignores the node existence check and just adds the new value.

@mbolgariw
Copy link
Contributor Author

hi @holograph , this pr is needed in the project originated by you :), in order to finally move from the 0.2.x version

@holograph
Copy link
Collaborator

Huh! Y’all still on 0.2.x?! Jesus. By all means, go for it...

@mbolgariw
Copy link
Contributor Author

mbolgariw commented Jul 11, 2019

@vishwakarma , @holograph :
i don't seem to have an option to either add reviewers or merge the PR.
please merge the PR, if it looks ok.

@vishwakarma vishwakarma merged commit 9c5b1f3 into flipkart-incubator:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants