Forbid remove missing flag #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, also love the fix, thanks! @vishwakarma I'm wondering if this shouldn't be the default behavior (breaking change + compatibility flag to regain "wrong" behavior), WDYT? |
holograph
approved these changes
Jan 31, 2022
|
Ping @vishwakarma ? |
vishwakarma
approved these changes
Feb 14, 2022
|
Thank you @luke-stead-sonocent |
|
Thank you both! If you do decide you want to change the behaviour so it defaults on, I'm happy to submit a PR. Just let me know. Thanks again! |
|
Sure |
|
Hi @luke-stead-sonocent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying a
removeoperation, the target value must exist https://datatracker.ietf.org/doc/html/rfc6902#section-4.2.This adds a compatibility flag which must be enabled to enforce this behaviour (to maintain compatibility by default with previous versions).
I've also fixed a couple of places where the
JsonPatchApplicationExceptioncontained the wrong information.