Removing apache commons & Guava dependency #60

vishwakarma · 2017-12-22T19:44:42Z

This commit contains --

removal of apache commons dependency
Writing own LCS since we no longer use apache commons lib.

…tion

LouizFC · 2017-12-23T21:17:36Z

This commit contains:

removal of guava library. Simple methods got inlined, others got moved to PathUtils.
creation of PathUtils:
It serves as a low level internal api for dealing with low level paths/jsonpointers.
also I pre-compiled regexes used in decoding, see Tiny optimisations #54

LouizFC · 2017-12-24T00:52:59Z

Maybe we could further optimize the lcs algorithm. I am gonna take a look at this: https://github.com/fillumina/LCS

vishwakarma · 2017-12-24T06:05:52Z

Sure @LouizFC
Regarding LCS, i don't think we could do better than O(N*M) but regardless of that I will have a look at the repo link which you shared.

vishwakarma · 2017-12-24T06:19:53Z

Hi @LouizFC
So far --

All test-suite passed ( one checked-in with this library and other one i have which contains 16M operations)
Earlier to run 16M operation test-suite, it used to take ~6 minutes 30 seconds, now it takes 5 minutes 57 seconds.

holograph · 2017-12-24T06:45:24Z

src/main/java/com/flipkart/zjsonpatch/InternalUtils.java

+class InternalUtils {
+
+    static List<JsonNode> toList(ArrayNode input) {
+        List<JsonNode> toReturn = new ArrayList<JsonNode>();


Should probably initialize with size hint (i.e parameter specifying capacity)

holograph · 2017-12-24T08:21:49Z

src/main/java/com/flipkart/zjsonpatch/InternalUtils.java

+
+    private static List<JsonNode> reverse(List<JsonNode> list) {
+        List<JsonNode> toReturn = new LinkedList<JsonNode>();
+        for (int i = list.size() - 1; i >= 0; i--) {


Would probably be better to forward-iterate the list (the interface makes no guarantees about time complexity on indexed retrieval/update) and build up an ArrayList (which does).

We could use Collections.reverse, which guarantees linear time complexity instead of this method

That requires a clone first, not sure it'll end up being any faster...

Inside InternalUtils.longestCommonSubsequence, we could use Collections.reverse ( it does in-place reversal ) before the return statement.
By your last comment, did you mean that sir?

It's possible, but may be slightly less readable. Bottom line, we don't have a benchmark suite yet, so the whole discussion is kind of moot :-)

I am using @cyber-front test-suite ( shared sometime back with both of us ) for benchmarking where it creates 65,536 random objects and performed a series of 256 updates on each.

holograph · 2017-12-24T08:22:32Z

src/main/java/com/flipkart/zjsonpatch/JsonDiff.java

-          /*
-         * Merging remove & add to move operation
-         */
+            /*


Why multi-line comments? Just makes everything more difficult...

Agreed, will make it Single line comment

holograph · 2017-12-24T08:30:34Z

src/main/java/com/flipkart/zjsonpatch/JsonDiff.java

-        Preconditions.checkArgument(second.isArray(), "LCS can only work on JSON arrays");
-
-        return ListUtils.longestCommonSubsequence(Lists.newArrayList(first), Lists.newArrayList(second));
+        return InternalUtils.longestCommonSubsequence(InternalUtils.toList((ArrayNode) first), InternalUtils.toList((ArrayNode) second));


Slight change in error semantics, parameters no longer checked for whether or not they are arrays. Intentional?

Since the caller already checks whether both inputs( source & target) are of Array type before calling this method, i thought to remove the additional checks.

Makes sense, but I checked and couldn't see the aforementioned check at the caller. Anyway it's only for clarity of errors when the API is misused, so not a critical point regardless.

Actually, caller of compareArray() methods checks the data-type of source & target.

LouizFC

I think it's all good now. We removed the dependencies and gained a little perfomance boost. My only issue was running the tests: I runned all tests, but some were failing in the beggining. I could not find in where in the .json file the test data was. I think adding a little more information when the tests fail (like file name and "message" field) may be beneficial. I can submit a PR for this later if wanted, since junit offers a message in the "assertEquals" method

…e Constants final

holograph · 2017-12-25T12:18:59Z

src/main/java/com/flipkart/zjsonpatch/InPlaceApplyProcessor.java

@@ -147,11 +147,11 @@ public void replace(List<String> path, JsonNode value) {
            if (isNullOrEmpty(fieldToReplace) && path.size() == 1)
                target = value;
            else if (parentNode.isObject())
-                ((ObjectNode) parentNode).put(fieldToReplace, value);
+                ((ObjectNode) parentNode).set(fieldToReplace, value);


Why the change? Is this semantically equivalent?

The old method is long deprecated in jackson api. But yes, the new one is equivalent

Now that you commented, this change shouldn't be in this commit, it passed without me noticing, sorry. I will let you decide if this should pass or not

This change got in to this commit without I noticing it. I will roll it back for now and wait for feedback.

vishwakarma · 2017-12-27T14:26:52Z

@LouizFC
Looks good, Thank you

This reverts commit 7973f70.

* removing apache commons dependency * Moved getArrayNodeRepresentation to PathUtils. Removed EncodePathFunction * Removed guava. * making 0.3.10-SNAPSHOT -> 0.3.11-SNAPSHOT & making few methods private * relacing reverse() with colelctions.reverse() and other review comments * commenting out print statements in tests * Renamed getArrayNodeRepresentation to getPathRepresentation. Also made Constants final * Rolled back a api change. This change got in to this commit without I noticing it. I will roll it back for now and wait for feedback.

LouizFC · 2017-12-27T18:44:33Z

You are welcome @vishwakarma. Thank you too for letting me take part in this, it was a pleasure. I look forward for helping more in the future, if you want, of course.

vishwakarma · 2017-12-27T18:49:08Z

@LouizFC , Your are open to propose any change in this project or to even start a new project. I would be available.
How can i connect you over gmail or other social network for future?

LouizFC · 2017-12-27T18:55:48Z

@vishwakarma I have added my email in to my github profile. Thank you for your interest.

vishwakarma added 2 commits December 23, 2017 01:11

removing apache commons dependency

c143533

Merge branch 'master' into size_zero

a450765

vishwakarma mentioned this pull request Dec 22, 2017

Interest to remove/migrate apache and guava dependencies #59

Closed

vishwakarma added the enhancement label Dec 22, 2017

Louiz added 2 commits December 23, 2017 17:37

Moved getArrayNodeRepresentation to PathUtils. Removed EncodePathFunc…

f3e4b73

…tion

Removed guava.

f00c2cf

vishwakarma requested a review from LouizFC December 24, 2017 06:06

vishwakarma assigned vishwakarma and LouizFC Dec 24, 2017

making 0.3.10-SNAPSHOT -> 0.3.11-SNAPSHOT & making few methods private

1c27265

holograph reviewed Dec 24, 2017

View reviewed changes

vishwakarma added 2 commits December 24, 2017 14:38

relacing reverse() with colelctions.reverse() and other review comments

d9affab

commenting out print statements in tests

4b2c7fc

LouizFC approved these changes Dec 24, 2017

View reviewed changes

Renamed getArrayNodeRepresentation to getPathRepresentation. Also mad…

8f8219e

…e Constants final

holograph reviewed Dec 25, 2017

View reviewed changes

Rolled back a api change.

e8f1a9a

This change got in to this commit without I noticing it. I will roll it back for now and wait for feedback.

vishwakarma merged commit 7973f70 into master Dec 27, 2017

vishwakarma added a commit that referenced this pull request Dec 27, 2017

Revert "Removing apache commons & Guava dependency (#60)"

8b8c80b

This reverts commit 7973f70.

ov7a mentioned this pull request Aug 15, 2018

Memory issue with 0.4.0+ #77

Closed

akshatpriyansh mentioned this pull request Aug 21, 2018

memory issue fix in LCS algo #78

Merged

LouizFC mentioned this pull request Nov 23, 2018

Encoding/Decoding of paths with escaping is broken #82

Closed

LouizFC mentioned this pull request Jan 25, 2019

RFC6901 compliance may present backward incompatible changes #89

Closed

mattnelson mentioned this pull request Dec 21, 2022

Critical CVE CVE-2017-7525 in zjsonpatch-0.3.0.jar fabric8io/kubernetes-client#3489

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing apache commons & Guava dependency #60

Removing apache commons & Guava dependency #60

vishwakarma commented Dec 22, 2017

LouizFC commented Dec 23, 2017 •

edited

Loading

LouizFC commented Dec 24, 2017

vishwakarma commented Dec 24, 2017

vishwakarma commented Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

holograph Dec 24, 2017

vishwakarma Dec 24, 2017

LouizFC left a comment •

edited

Loading

holograph Dec 25, 2017

LouizFC Dec 25, 2017 •

edited

Loading

LouizFC Dec 25, 2017

vishwakarma commented Dec 27, 2017

LouizFC commented Dec 27, 2017 •

edited

Loading

vishwakarma commented Dec 27, 2017

LouizFC commented Dec 27, 2017

Removing apache commons & Guava dependency #60

Removing apache commons & Guava dependency #60

Conversation

vishwakarma commented Dec 22, 2017

LouizFC commented Dec 23, 2017 • edited Loading

LouizFC commented Dec 24, 2017

vishwakarma commented Dec 24, 2017

vishwakarma commented Dec 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LouizFC left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LouizFC Dec 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishwakarma commented Dec 27, 2017

LouizFC commented Dec 27, 2017 • edited Loading

vishwakarma commented Dec 27, 2017

LouizFC commented Dec 27, 2017

LouizFC commented Dec 23, 2017 •

edited

Loading

LouizFC left a comment •

edited

Loading

LouizFC Dec 25, 2017 •

edited

Loading

LouizFC commented Dec 27, 2017 •

edited

Loading