-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Add flags & namespaces api #127
Conversation
Hey @jarviliam Thanks for the contribution and sorry for the slow reply! Previously we were using a tool to handle auto-generating clients in multiple languages. That said though, we do intend to maintain these management APIs in Flipt and ensure backward compatibility for them. However, we intend to keep these particular SDK clients isolated to evaluation only for now. We would love to understand what you're use case is here for these APIs. I could see how adding support for |
@markphelps Understandable! Feel free to close out this PR then 👌
The main use-case missing from these sdks is really Thanks for all the work on Flipt! |
@jarviliam I think list flags 💯 percent makes sense to add to all our revamped sdks. Would you mind pairing this PR down to adding list flags for python and I will make sure we implement it for other languages as well? We just did the same for our client side evaluation sdks |
810331b
to
9acf025
Compare
@markphelps Ran the linter and rebased on latest 🙇 |
9acf025
to
5f9ace5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers! thanks @jarviliam !!
Summary
Adds the apis for Flag and Namespace operations.
Test sessions will run under a uuid4 generated namespace so that theres no conflict between mutiple test runs
My company uses these flag/namespace operations so having them in the official server-sdk would make it easier to adopt. I just assumed that they are missing here but if there are actually no plans to implement them just let me know and I'll close this PR 👍