Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending ABRP update without SoC #657

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

cascer1
Copy link
Contributor

@cascer1 cascer1 commented Nov 7, 2023

The ABRP battery prediction algorithm doesn't work when live data is uploaded without State of Charge (soc) field. This commit avoids sending
such updates.

Resolves #656

@flobz flobz changed the base branch from develop to master November 14, 2023 14:02
@flobz flobz changed the base branch from master to develop November 14, 2023 14:02
@flobz flobz changed the base branch from develop to master November 14, 2023 14:07
The ABRP battery prediction algorithm doesn't work when live data is
uploaded without State of Charge (soc) field. This commit avoids sending
 such updates.

(cherry picked from commit d8ca85c)
@flobz flobz force-pushed the develop branch 2 times, most recently from 3633551 to 58f08e1 Compare November 14, 2023 14:50
@flobz flobz merged commit 8b0c625 into flobz:master Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABRP: Don't send update without battery level
2 participants