Add 2.3 e2e boxgen,move-to-other-layers,qrcode #196
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .should('contain', 'Top') | ||
| .should('contain', 'Bottom') | ||
| .should('contain', 'Front') | ||
| .should('contain', 'Back') |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/semi> reported by reviewdog 🐶
Missing semicolon.
| .should('contain', 'Back') | |
| .should('contain', 'Back'); |
| .then((html) => expect(md5(html)).equal('d41d8cd98f00b204e9800998ecf8427e')); | ||
|
|
There was a problem hiding this comment.
🚫 [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.
| .then((html) => expect(md5(html)).equal('d41d8cd98f00b204e9800998ecf8427e')); | |
| .then((html) => expect(md5(html)).equal('d41d8cd98f00b204e9800998ecf8427e')); |
|
|
||
| it('move', () => { | ||
| cy.clickToolBtn('Line'); | ||
| cy.get('svg#svgcontent') |
There was a problem hiding this comment.
Do not use force on click and type calls
| it('move', () => { | ||
| cy.clickToolBtn('Line'); | ||
| cy.get('svg#svgcontent') | ||
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true }) |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break after this opening brace.
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true }) | |
| .trigger('mousedown', { | |
| which: 1, pageX: 100, pageY: 100, force: true }) |
| it('move', () => { | ||
| cy.clickToolBtn('Line'); | ||
| cy.get('svg#svgcontent') | ||
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true }) |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break before this closing brace.
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true }) | |
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true | |
| }) |
| cy.clickToolBtn('Line'); | ||
| cy.get('svg#svgcontent') | ||
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true }) | ||
| .trigger('mousemove', { which: 1, pageX: 200, pageY: 200, shiftKey: true, force: true }) |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break after this opening brace.
| .trigger('mousemove', { which: 1, pageX: 200, pageY: 200, shiftKey: true, force: true }) | |
| .trigger('mousemove', { | |
| which: 1, pageX: 200, pageY: 200, shiftKey: true, force: true }) |
| cy.clickToolBtn('Line'); | ||
| cy.get('svg#svgcontent') | ||
| .trigger('mousedown', { which: 1, pageX: 100, pageY: 100, force: true }) | ||
| .trigger('mousemove', { which: 1, pageX: 200, pageY: 200, shiftKey: true, force: true }) |
There was a problem hiding this comment.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Expected a line break before this closing brace.
| .trigger('mousemove', { which: 1, pageX: 200, pageY: 200, shiftKey: true, force: true }) | |
| .trigger('mousemove', { which: 1, pageX: 200, pageY: 200, shiftKey: true, force: true | |
| }) |
| cy.get( | ||
| '[class*="src-web-app-components-beambox-right-panel-AddLayerButton-module__btn"]' | ||
| ).click({ force: true }); |
There was a problem hiding this comment.
Do not use force on click and type calls
| cy.checkToolBtnActive('Cursor'); | ||
| cy.get('.layers > .tab-icon').click(); | ||
| cy.get( | ||
| '[class*="src-web-app-components-beambox-right-panel-AddLayerButton-module__btn"]' |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
| '[class*="src-web-app-components-beambox-right-panel-AddLayerButton-module__btn"]' | |
| '[class*="src-web-app-components-beambox-right-panel-AddLayerButton-module__btn"]', |
| cy.get('.react-contextmenu') | ||
| .contains('Move elements to:') | ||
| .trigger('mouseover'); | ||
| cy.wait(1000); |
There was a problem hiding this comment.
🚫 [eslint] <cypress/no-unnecessary-waiting> reported by reviewdog 🐶
Do not wait for arbitrary time periods
boxgen.spec.ts
move-to-other-layers.spec.ts
qrcode.spec.ts