feat: Open files/folder in the file explorer #1117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds an option that will open a file explorer highlighting the file/folder selected. Still needs to be a little more careful on error handling
Interesting - the docs and the implementation suggest that it doesn't take care of being non-blocking nor being detached from the rnote process. I think on my Gnome installation it ends up being okay because it launches through dbus but for other systems/file-managers this might be an issue. Need to test it more with different distributions. Otherwise going with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #1089 after a github mess...
To fix #1053
I switched to opener and added the action to open the workspace folder in the folder submenu.
This is a PR that's very similar to #868, using a slightly different crate (opener) that has a reveal call and a MIT OR Apache-2.0 license.
The implementation detail for this is here https://docs.rs/opener/latest/opener/fn.reveal.html
The open crate doesn't have this option afaik but having two crates doing very similar things is slightly redundant
Tested only on linux aarch64 for now (but should be supported on all platforms)
One thing to verify is that opener does not have the same open::that_detached option, only opener::open and I don't know if that makes a difference or not