Feat(cast): Add --parse-bytes32-address

[0xSileo]

Motivation

Add the --parse-bytes32-address option to cast. Earlier today, I was reading storage values and couldn't find a way to parse them into a checksummed address, i.e. go from this : 0x000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045 to this : 0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045.

Solution

Implemented it

Other

I'm new to Rust and contributing (and quite proud of this PR actually), so feel free to provide any feedback.

[mattsse]

ty, smol nit.

would appreciate a book pr once merged

[tynes]

Perhaps a more generic type to type converter would be more useful? Going from uint256 to bytes32 or vice versa is similar and adding commands for each possible conversion is not ideal

[mds1]

Yea I had the same thought as @tynes, I'd suggest cast parse <fromType> <toType> <value>. For example:

$ cast parse bytes32 address 0x000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045
0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045

cast convert could be another good name. IMO the current --from-* and --to-* flags are quite cluttered and hard to keep track of. I'd prefer to to simplify them with a generic function instead of adding to that list.

[mds1]

Also just noting you can achieve this currently using the --abi-decode method with a dummy signature, such as:

$ cast --abi-decode "x()(address)" 0x000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045
0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045

[tynes]

Also just noting you can achieve this currently using the --abi-decode method with a dummy signature, such as:

$ cast --abi-decode "x()(address)" 0x000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045
0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045

Definitely prefer adding this to the docs and making it the "canonical" solution to this problem, or cast convert. Reasoning is to not clutter the tool

[0xSileo]

Also just noting you can achieve this currently using the --abi-decode method with a dummy signature, such as:

$ cast --abi-decode "x()(address)" 0x000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045
0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045

I thought about doing something like this, as I knew about specifying output types (e.g. "totalSupply()(uint)") but couldn't figure out a way to do it.

The abi-decode way of doing it works but is a bit hacky imo. Therefore, I'm in favor of adding a convert command, which would be more general and could remove a certain amount of clutter, as stated by both of you.

Should we open a new issue and close this PR (or merge it while the convert is not implemented) ?

I'll try to implement convert, seems challenging but doable for me.

[mds1]

Should we open a new issue [for convert] and close this PR

Personally this would be my preferred approach, @mattsse @tynes lmk if you have any objections

sorry for the churn here @51730 :)

[mattsse]

I'm fine with this, if we want a more generic converter this can be extra