-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump ethers #5086
feat: bump ethers #5086
Conversation
Needs updates on solc breaking changes. Also this makes |
@mattsse wdyt of still keeping paris as the default EVM version and overriding ethers's? |
@@ -1723,7 +1723,7 @@ impl Default for Config { | |||
allow_paths: vec![], | |||
include_paths: vec![], | |||
force: false, | |||
evm_version: Default::default(), | |||
evm_version: EvmVersion::Paris, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah let's keep Paris
there's a no activated error which perhaps is caused by the diff defaults? |
Yup, there's also still a few changes left to properly handle leaving paris as default, just testing everything carefully before removing draft |
alright, so tests fixed @mattsse . I've pinned them to use 0.8.18—if not, we would run into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinning to 0.8.18 makes sense imo
Ethers 2.0.6 was recently released, and contains a few useful bugfixes, especially regarding verification.