feat: bump ethers #5086
Merged
feat: bump ethers #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs updates on solc breaking changes. Also this makes |
Evalir
changed the title
Evalir
changed the title
|
@mattsse wdyt of still keeping paris as the default EVM version and overriding ethers's? |
mattsse
approved these changes
May 31, 2023
| @@ -1723,7 +1723,7 @@ impl Default for Config { | |||
| allow_paths: vec![], | |||
| include_paths: vec![], | |||
| force: false, | |||
| evm_version: Default::default(), | |||
| evm_version: EvmVersion::Paris, | |||
there's a no activated error which perhaps is caused by the diff defaults? |
|
Yup, there's also still a few changes left to properly handle leaving paris as default, just testing everything carefully before removing draft |
|
alright, so tests fixed @mattsse . I've pinned them to use 0.8.18—if not, we would run into the |
mattsse
approved these changes
Jun 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethers 2.0.6 was recently released, and contains a few useful bugfixes, especially regarding verification.