-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump strum #5189
chore: bump strum #5189
Conversation
odyslam
commented
Jun 20, 2023
- bump strum
- rust-analyzer style, lmk if we like them or we want to revert to original
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also needs to bump the lock file?
or is it 0.25 there already?
Without this PR, forge does not compile if consumed as a lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to bump chisel's cargo.toml
@odyslam pending broken build |
sorry but this is still failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but had to nuke the cargo lock for this to build. Unsure why this was happening. Maybe there was a weird version mismatch somewhere here.