Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump strum #5189

Merged
merged 4 commits into from
Jun 22, 2023
Merged

chore: bump strum #5189

merged 4 commits into from
Jun 22, 2023

Conversation

odyslam
Copy link
Contributor

@odyslam odyslam commented Jun 20, 2023

  • bump strum
  • rust-analyzer style, lmk if we like them or we want to revert to original

mattsse
mattsse reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs to bump the lock file?
or is it 0.25 there already?

@mattsse mattsse added the L-ignore Log: ignore PR in changelog label Jun 20, 2023
@odyslam
Copy link
Contributor Author

odyslam commented Jun 20, 2023

Without this PR, forge does not compile if consumed as a lib

Evalir
Evalir requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to bump chisel's cargo.toml

@mattsse
Copy link
Member

mattsse commented Jun 20, 2023

@odyslam pending broken build

@mattsse
Copy link
Member

mattsse commented Jun 22, 2023

sorry but this is still failing

Evalir
Evalir approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but had to nuke the cargo lock for this to build. Unsure why this was happening. Maybe there was a weird version mismatch somewhere here.

@Evalir Evalir merged commit 2097194 into foundry-rs:master Jun 22, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Evalir approved these changes

Assignees
No one assigned
Labels
L-ignore Log: ignore PR in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odyslam @mattsse @Evalir