Support the gcp option in cast wallet list
#8232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moricho
requested review from
klkvr,
DaniPopes,
Evalir and
mattsse
as code owners
mattsse
requested changes
Jun 23, 2024
| @@ -394,6 +401,34 @@ impl MultiWalletOpts { | |||
|
|
|||
| Ok(None) | |||
| } | |||
|
|
|||
| // TODO: Support multiple keys | |||
| pub async fn gcp_signers(&self) -> Result<Option<Vec<WalletSigner>>> { | |||
There was a problem hiding this comment.
can we add a few docs here that describe what this does?
crates/cast/bin/cmd/wallet/list.rs
Outdated
Comment on lines
56
to
57
| .aws(self.aws || self.all) | ||
| .gcp(self.gcp || self.all) |
There was a problem hiding this comment.
this makes me realize that if --all is set, the command will always fail if the env vars are missing, same for aws, which is probably not great UX.
we could make gcp infallible if the env vars are missing, same for aws.
moricho
force-pushed
the
wallet-gcp-option
branch
2 times, most recently
from
315d8ea
to
1d971c9
Compare
moricho
force-pushed
the
wallet-gcp-option
branch
from
1d971c9
to
e2f5814
Compare
|
@mattsse Could you take another look when you have time? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To list an account from GCP KMS as with the other options.
Related to this comment in the PR.
Solution
Adds a
gcpflag to theMultiWalletand to theListArgsof thecask wallet.NOTE: The current implementation only supports a single key, but multiple keys should be supported in the next step