-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EOF): enable EOF inspector #8305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a new alloy + revm with a few additional breaking changes
Cargo.toml
Outdated
Comment on lines
267
to
269
[patch.crates-io] | ||
foundry-compilers = { git = "https://github.com/foundry-rs/compilers", rev = "b0f6fe6" } | ||
revm-inspectors = { git = "https://github.com/paradigmxyz/revm-inspectors", rev = "bd9cc40" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this for this pr?
Merged
* bump alloy and revm * fix test * rm patch * update lock
klkvr
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed few things for EOF support and enabled
eofcreate
andeofcreate_end
to be called inInspectorStack
forge-eof partially works
It Reverts on: https://github.com/fgimenez/forge-eof/blob/b90f38ea451f44be5813d866ef953d89e9512544/src/UniswapV3Flattened.sol#L5165
And I need to comment out this line: https://github.com/fgimenez/forge-eof/blob/b90f38ea451f44be5813d866ef953d89e9512544/src/UniswapV3Flattened.sol#L2078
It seems there is some problem how this address gets calculated, this ties address in initcode and address of deployed contract.