Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): add snapbox #8406

Merged
merged 6 commits into from
Jul 11, 2024
Merged

refactor(tests): add snapbox #8406

merged 6 commits into from
Jul 11, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Jul 10, 2024 •
edited
Loading

Motivation

first step for #8389

Solution

DaniPopes
DaniPopes reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

crates/cast/tests/cli/main.rs Outdated Show resolved Hide resolved
crates/forge/tests/cli/create.rs Outdated Show resolved Hide resolved
@mattsse mattsse enabled auto-merge (squash) July 11, 2024 05:46
@mattsse mattsse merged commit d0ba6a2 into master Jul 11, 2024
21 checks passed
@mattsse mattsse deleted the klkvr/snapbox branch July 11, 2024 06:00
@DaniPopes DaniPopes mentioned this pull request Jul 11, 2024
Merged
@klkvr klkvr mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klkvr @mattsse @DaniPopes