add page with guide to install mcap with cmake #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indirectlylit
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Hi @filippobrizzi, thanks for adding this! I think it will certainly help other CMake users out there.
I think also adding a reference in this file would help people find it: https://github.com/foxglove/mcap/blob/main/cpp/README.md
I opened a very minor PR to your readme file here: olympus-robotics/mcap_builder#2
Co-authored-by: Devon Rueckner <[email protected]>
|
Thanks @indirectlylit! I have updated with your comments. |
Co-authored-by: Devon Rueckner <[email protected]>
|
done! thanks for this contribution, and sorry we weren't able to bake cmake support directly into the repo at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add a page to
websitewith the guide on how to install MCAP with Cmake.Description
This follows conversation from https://foxglove.slack.com/archives/C02H1JXG3C3/p1719462475680899