Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify patch version and sync #1192

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Specify patch version and sync #1192

merged 1 commit into from
Jul 26, 2024

Conversation

bryfox
Copy link
Contributor

@bryfox bryfox commented Jul 5, 2024

This updates the go workspace to specify a version of go, and syncs the workspace.

When I used the existing workspace locally, go commands failed, because it could not install a toolchain for version "1.22". These (omitted patch) versions are development versions, which are removed once out of development.

The docs still imply that work init produces a file with an omitted patch version, but it seems to now init with a specific version (1.22.5), and this comment indicates it's required: golang/go#62278 (comment). Presumably I could manually install a version of 1.22, but using a specific version makes the tooling work nicely.

Copy link

@eloff eloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'll try it out later today

@eloff
Copy link

eloff commented Jul 26, 2024

I don't think this is an issue with your PR, but just so you're aware with latest golangci-lint v1.59.1:

~/foxglove/mcap/go$ make lint
make -C mcap lint
make[1]: Entering directory '/home/eloff/foxglove/mcap/go/mcap'
golangci-lint run ./...
WARN The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
WARN The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
WARN The linter 'ifshort' is deprecated (since v1.48.0) due to: The repository of the linter has been deprecated by the owner.  
ERRO [linters_context] deadcode: This linter is fully inactivated: it will not produce any reports. 
ERRO [linters_context] ifshort: This linter is fully inactivated: it will not produce any reports. 
ERRO [linters_context] varcheck: This linter is fully inactivated: it will not produce any reports. 
make[1]: *** [Makefile:8: lint] Error 7
make[1]: Leaving directory '/home/eloff/foxglove/mcap/go/mcap'
make: *** [Makefile:8: lint] Error 2

@eloff eloff self-requested a review July 26, 2024 14:26
Copy link

@eloff eloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryfox bryfox merged commit a054375 into main Jul 26, 2024
24 checks passed
@bryfox bryfox deleted the bryan/go-1.22.5 branch July 26, 2024 15:10
@bryfox bryfox mentioned this pull request Jul 26, 2024
bryfox added a commit that referenced this pull request Jul 26, 2024
This upgrades the version of `golangci-lint` to the latest version, and
removes three deprecated linters, which now error when included because
they are completely unused:
#1192 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants