Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated windows CI #50

Merged
merged 1 commit into from
Jul 29, 2023
Merged

updated windows CI #50

merged 1 commit into from
Jul 29, 2023

Conversation

sezero
Copy link
Contributor

@sezero sezero commented Jul 26, 2023

Please also merge #47 which is needed for dll generation.

@sezero
Copy link
Contributor Author

sezero commented Jul 26, 2023

Rebased to master after merge of #47

fragglet
fragglet requested changes Jul 26, 2023
View reviewed changes
.github/workflows/make.yml Outdated Show resolved Hide resolved
.github/workflows/make.yml Show resolved Hide resolved
.github/workflows/make.yml Outdated Show resolved Hide resolved
@sezero
Copy link
Contributor Author

sezero commented Jul 26, 2023

Squashed all commits. Should be ready.

@sezero sezero requested a review from fragglet July 26, 2023 01:06
fragglet
fragglet approved these changes Jul 29, 2023
View reviewed changes
Copy link
Owner

@fragglet fragglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might rework this a bit but I'm fine with merging it as it is.

@fragglet fragglet merged commit 18bbcc3 into fragglet:master Jul 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fragglet fragglet fragglet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sezero @fragglet