Fix compiler warnings #10
Conversation
| // about the app to say other wise | ||
| // | ||
| // Feel free to replace | ||
| self.inner.send_event(event).unwrap(); |
There was a problem hiding this comment.
I'd not recommand unwrap here, because it's not an issue that should panic.
In the long term, I think it would be a better idea to send the Result to the application layer and handle them there.
| let mut content_size = Vec2::default(); | ||
| let button_padding = ui.spacing().button_padding; | ||
|
|
||
| if self.editable { |
There was a problem hiding this comment.
Seems weird using editable in L51, but uses self.editable again here. Same L72, L82, L98, L114.
| // about the app to say other wise | ||
| // | ||
| // Feel free to replace | ||
| select_system_locales().unwrap(); |
There was a problem hiding this comment.
Recommand not to unwrap here. You can just ignore it or simply log the error (better).
| // about the app to say other wise | ||
| // | ||
| // Feel free to replace | ||
| select_locales(&[language.id]).unwrap(); |
There was a problem hiding this comment.
Same here. I18n issues should not panic the whole program.
| .on_hover_text(fl!("control_capture")) | ||
| .clicked() | ||
| { | ||
| if state.can_capture { |
There was a problem hiding this comment.
Screen capturing is not triggered by play button. The capture button should not be removed if there is not specific reasons.
|
Thanks! I've done a quick review. Apart from that, it's recommanded to use And better to re-organise commits (Currently there are two commits with the same description). Try BTW, are you using analyst tools other than |
Might need a quick review, I've added unwraps to functions that return results, but that might not be the best idea.
Other than that, should be good