Skip to content

Commit

Permalink
ksmbd: common: use struct_group_attr instead of struct_group for netw…
Browse files Browse the repository at this point in the history
…ork_open_info

commit 0268a7c upstream.

4byte padding cause the connection issue with the applications of MacOS.
smb2_close response size increases by 4 bytes by padding, And the smb
client of MacOS check it and stop the connection. This patch use
struct_group_attr instead of struct_group for network_open_info to use
 __packed to avoid padding.

Fixes: 0015eb6 ("smb: client, common: fix fortify warnings")
Cc: [email protected]
Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Steve French <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
namjaejeon authored and gregkh committed Apr 27, 2024
1 parent 4687606 commit 67a8771
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/smb/common/smb2pdu.h
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ struct smb2_close_rsp {
__le16 StructureSize; /* 60 */
__le16 Flags;
__le32 Reserved;
struct_group(network_open_info,
struct_group_attr(network_open_info, __packed,
__le64 CreationTime;
__le64 LastAccessTime;
__le64 LastWriteTime;
Expand Down

0 comments on commit 67a8771

Please sign in to comment.