-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSP memory holds FIR coefficients in reverse order #105
Comments
HI, please can you verify wether the issue is solved in v2.2.2? I have added the coefficient order reversing to the ESP32 firmware. |
Are there PEQs involved in your setting? |
P.S. between 100 and 200 Hz I see a phase change, too. Can it be that you have enabled another filter (PEQ or Phase)? |
No Aurora PEQ were involved. All 10 PEQs had Gain 0. Tested with clean 2.2.1 and pre 2.2.2 FW. Only FIR-inside EQs generated via rePhase. |
Is there a way to show how the FIR should look like? So what did you design and does Aurora reproduce that correctly. |
Yes, the first picture with 2.1.4 shows my Woofer with linear phase close to zero. This was only tuned by rePhase EQs and should look like that ;-) |
ok, plz can you send me the text file you uploaded to aurora? I want to make sure that this is processed correctly. |
You got mail. |
Yes saw it while I was typing here. Can I conclude from your previous post, that this issue is solved now? |
Yes this reversed coef thing is solved for me. |
Great! Can't wait to use FIR more often now |
I will verify this today evening. |
Hi, |
* freeDSP-master: (23 commits) Added argument check to release script Increased PEQ-Bands to 10 fpr 4FIRs plugin Fixed issue freeDSP#94 and freeDSP#106 Fixed issue freeDSP#89 Bash script for release deploying sigma2aurora.py accepts output directory Fixed wrong id syntax in sigma2aurora.py Fixed wrong AddOn header in GUI Updated README.md Fixed hostname Fix for issue freeDSP#105 Custom DSP name Fixed issue freeDSP#107 Fix for freeDSP#102 Hide AddOn if needed Fixed SPDIF routing for Virtual Inputs Arrange PEQ bands in two rows Apple remote codes updated Fix relative link Make it clear esp32make is an alternative/experimental method ... # Conflicts: # SOURCES/WEBAPP/ESP32/aurora/aurora.ino # SOURCES/WEBAPP/ESP32/aurora/hwconfig.h
Hello,
tests reveal a maximum phase behaviour of current FIR implementation.
This seems to be caused by incorrect order of coefficient upload. According to this:
https://wiki.analog.com/resources/tools-software/sigmastudio/toolbox/filters/firfilter
Coefficents need to be loaded in reverse order.
As a quick workaround coefficients may be swapped prior upload by a script or via command line e.g:
tail -r LIN.txt > LIN_rev.txt
The text was updated successfully, but these errors were encountered: