-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH actions to use R 3.x #235
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 571 571
=========================================
Hits 571 571 ☔ View full report in Codecov by Sentry. |
It seems that we need to set an higher minimal R version if we want to use readr and testthat See https://github.com/frictionlessdata/frictionless-r/actions/runs/9856342939/job/27213129214?pr=235, in particular the error message:
I will check using 3.6 now. |
R 3.6 seems also not working using the most recent versions of the dependencies. See error in action: https://github.com/frictionlessdata/frictionless-r/actions/runs/9856412491/job/27213351610?pr=235 In particular, the error message:
Still, notice that the packages generating the errors are suggested ( Testing using 3.6.3, same as in camtraptor. |
No, even using 3.6.3 doesn't solve the issue. See action https://github.com/frictionlessdata/frictionless-r/actions/runs/9856412491/job/27213351610?pr=235 In particular, see error message:
Again, packages generating the errors are not imported, but "only" suggested. |
Even removing the minimal version of testthat (3.0.0) doesn't improve the situation. The problem is still the package I have just installed R 3.5 on my (Windows) machine and tried to install frictionless. It seems not possible. The problems are (at least) related with cli package which blocks the installations of dplyr and purrr. Notice that for this old version of R many packages need to be installed by source. cli, by the way, run automatic R CMD CHECK tests for R 4.0.5 or higher. But in its DESCRIPTION mentions R 3.4 as minimal version. So, we are not the only having this discrepancy between nominal minimal version and the actual version. @peterdesmet, @sannegovaert, @PietrH: I think we should at least warn the users to install R 4.0.0 or higher in README. Any thought? |
I've just tried running R CMD CHECK on a freshly cloned version of this repo (3395464) , on R 3.6.4:
|
my session info > sessioninfo::session_info()
─ Session info ───────────────────────────────────────────────────────────────────────
setting value
version R version 3.6.3 (2020-02-29)
os Ubuntu 16.04.7 LTS
system x86_64, linux-gnu
ui RStudio
language (EN)
collate en_US.UTF-8
ctype en_US.UTF-8
tz Europe/Brussels
date 2024-07-09
─ Packages ───────────────────────────────────────────────────────────────────────────
package * version date lib source
cli 3.6.2 2023-12-11 [2] CRAN (R 3.6.3)
packrat 0.5.0 2018-11-14 [2] CRAN (R 3.6.0)
sessioninfo 1.1.1 2018-11-05 [2] CRAN (R 3.6.0)
withr 3.0.0 2024-01-16 [2] CRAN (R 3.6.3)
[1] /data/home/innovauth/pieter.huybrechts@inbo.be/R/x86_64-pc-linux-gnu-library/3.6
[2] /usr/local/lib/R/site-library
[3] /usr/lib/R/site-library
[4] /usr/lib/R/library This is on the lifewatch rstudio server, I'll try locally on Ubuntu LTS as well |
We are dependent on R4.1.0: USCbiostats/fmcmc#20 (comment) Because of the function: frictionless-r/R/add_resource.R Lines 137 to 143 in 3395464
|
I've now installed frictionless locally from a new R3.6.3 installation on a Ubuntu 20.04 LTS 3 machine:
I'll now continue with suggested packages and rerun R CMD CHECK |
@damianooldoni Is right, I can't install However, while the CRAN version of evalutate requires R4.0, the dev version on github only needs R3.6: r-lib/evaluate@e00724f I was able to get evaluate installed with: remotes::install_github("r-lib/evaluate") As a note, we could maybe stop the CI from trying to install the suggested packages:
|
I'm failing on
|
It seems evalutate is dropping support for R versions lower than 4 by design: r-lib/evaluate#173 |
@damianooldoni we are abandoning this PR in favour of #240, which sets the minimum R requirement to 4.0.0 in alignment with tidyverse. I won't warn in README, but will indicate NEWS.md that R 4.0.0 is required. |
Ok, @peterdesmet! Thanks for reporting it. |
This PR adds an automated configuration OS/R version for R-CMD-CHECK action. In particular, we would like to check that users using the minimal R supported version (3.5) can install the package and use it without any error.