Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asset precompile config initializer #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javierjulio
Copy link

@javierjulio javierjulio commented Jul 3, 2019

This is unnecessary as an asset gem. As shown in the docs for wysiwyg-rails gem, these files are required in manifest files that are already part of a Rails applications' precompile config. There is no need to also precompile these files too which causes a very large amount of files being generated when running rails assets:precompile (an extra file for each due to GZ).

I'm able to update or include any other changes that are necessary, just let me know. Happy to help. This resolves #56 which should be reopened. Update: created a new issue in #83.

Fixes #83

@javierjulio
Copy link
Author

javierjulio commented Jul 5, 2019

UPDATE: tests now passing

There is only one build failure: Ruby 1.9.3 where it can't seem to find a download. It seems this version isn't available. This is affecting all builds for awhile now. Note there are several release commits in master with the same failed builds.

$ rvm use 1.9.3 --install --binary --fuzzy
curl: (22) The requested URL returned error: 404 Not Found
Required ruby-1.9.3 is not installed - installing.
curl: (22) The requested URL returned error: 404 Not Found
Searching for binary rubies, this might take some time.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm ruby-1.9.3 do rvm gemset create ' first, or append '--create'.
The command "rvm use 1.9.3 --install --binary --fuzzy" failed and exited with 2 during .

This is unnecessary as an asset gem. As shown in the docs for wysiwyg-rails, these files are required in manifest files that are part of a Rails applications' precompile config. There is no need to also precompile these files too which causes a very large amount of files being generated when running `rails assets:precompile` (an extra file for each due to GZ).
@javierjulio
Copy link
Author

Rebased. All tests are now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not precompile all asset files by default No reason to precompile all the assets
1 participant