Modernize edition, bump deps, fix traits #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my fork that now contains 3 different changes:
The first was when dealing with slack-hook in a setting where we needed the errors to be shareable between actix. Error chain is not great for that, but there are other alternatives. failure was just an easy one. We never had any need for more than rudimentary error handling in this library anyway.
Feel free to cherry-pick or review. I do realise this project has not received much maintenance the last year, so for now will just publish a fork via a branch in my upstream. But putting this PR here as a just in case ❤️