clean up

core/bandmap/bandmap.go

@@ -664,8 +664,6 @@ func (l *Entries) cleanOutFalseEntries() {
 			switch CheckFalseEntry(entry1.BandmapEntry, entry2.BandmapEntry) {
 			case DifferentEntries:
 				continue
-			case EqualEntries:
-				// TODO: merge entry2 into entry1
 			case FirstIsFalse:
 				removedEntries = append(removedEntries, *entry1)
 				l.entries[i] = nil

core/bandmap/false_entry_check.go

@@ -12,7 +12,6 @@ type FalseEntryCheckResult int
 
 const (
 	DifferentEntries FalseEntryCheckResult = iota
-	EqualEntries
 	FirstIsFalse
 	SecondIsFalse
 )
@@ -33,9 +32,7 @@ func CheckFalseEntry(entry1, entry2 core.BandmapEntry) FalseEntryCheckResult {
 	case !callsignSimilar:
 		return DifferentEntries
 	case !frequencySimilar:
-		return DifferentEntries // TODO if one entry is much older than the other, the older one is false
-	case callsignEqual:
-		return EqualEntries
+		return DifferentEntries
 	case callsignSimilar && firstHasFalseSpotCount:
 		return FirstIsFalse
 	case callsignSimilar && secondHasFalseSpotCount:

core/bandmap/false_entry_check_test.go

@@ -27,32 +27,6 @@ func Test(t *testing.T) {
 			},
 			expected: DifferentEntries,
 		},
-		{
-			desc: "equal callsign, equal frequency",
-			entry1: core.BandmapEntry{
-				Call:      callsign.MustParse("DL0ABC"),
-				SpotCount: 100,
-			},
-			entry2: core.BandmapEntry{
-				Call:      callsign.MustParse("DL0ABC"),
-				SpotCount: 1,
-			},
-			expected: EqualEntries,
-		},
-		{
-			desc: "equal callsign, similar frequency",
-			entry1: core.BandmapEntry{
-				Call:      callsign.MustParse("DL0ABC"),
-				Frequency: 7000000,
-				SpotCount: 100,
-			},
-			entry2: core.BandmapEntry{
-				Call:      callsign.MustParse("DL0ABC"),
-				Frequency: 7000050,
-				SpotCount: 1,
-			},
-			expected: EqualEntries,
-		},
 		{
 			desc: "similar callsign, same frequency, second more spots than first",
 			entry1: core.BandmapEntry{