attempt to fix integration tests in CI #45
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The integration tests don't work after all. Exit code 137 indicates that the docker container runs out of memory. |
|
After checking RAM usage in Actions with https://github.com/marketplace/actions/workflow-telemetry, no noticeable difference when running all tests or just one test, however in the latter case it doesn't crash. In any case RAM usage stays around 1GB and GitHub runners have 7GB of RAM allocated to them, of which all should be utilized by Docker by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #41
Mocha 4.0 version disabled the --exit flag by default, which leaves some tests hanging if there is a database connection still open. In our case the database connection is made before the tests are run and it's closed independently from the tests, so I don't see an issue with adding the --exit flag back.