Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jira integration #91

Merged
merged 29 commits into from
Jul 4, 2024
Merged

Jira integration #91

merged 29 commits into from
Jul 4, 2024

Conversation

kurukimi
Copy link
Contributor

@kurukimi kurukimi commented Jun 5, 2024

No description provided.

@kurukimi kurukimi requested a review from joonashak June 12, 2024 11:15
@kurukimi kurukimi marked this pull request as ready for review June 12, 2024 11:18
@joonashak joonashak self-assigned this Jun 12, 2024
@joonashak
Copy link
Collaborator

Need documentation for at least:

  • New environment variables.
  • How to create credentials for Atlassian integration.

joonashak
joonashak reviewed Jul 2, 2024
View reviewed changes
server/src/main.ts Outdated Show resolved Hide resolved
server/src/jira/jira.controller.ts Outdated Show resolved Hide resolved
server/src/jira/jira.module.ts Outdated Show resolved Hide resolved
server/src/jira/jira.service.ts Outdated Show resolved Hide resolved
server/src/jira/jira.strategy.ts Outdated Show resolved Hide resolved
server/src/jira/session-setup.ts Outdated Show resolved Hide resolved
joonashak
joonashak reviewed Jul 2, 2024
View reviewed changes
server/src/jira/jira.service.ts Outdated Show resolved Hide resolved
server/src/jira/session-setup.ts Outdated Show resolved Hide resolved
server/src/jira/session-setup.ts Outdated Show resolved Hide resolved
server/src/config/config.ts Outdated Show resolved Hide resolved
joonashak
joonashak reviewed Jul 4, 2024
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
joonashak
joonashak reviewed Jul 4, 2024
View reviewed changes
server/src/jira/token.guard.ts Outdated Show resolved Hide resolved
server/src/jira/token.guard.ts Outdated Show resolved Hide resolved
server/src/jira/token.guard.ts Show resolved Hide resolved
joonashak
joonashak reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@joonashak joonashak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add CORS_ORIGIN: http://localhost:3000 to services.server.environment in compose.yaml to make local dev env work wihout having to add this to .env (not a secret and always the same value).

@joonashak joonashak merged commit 22c9ed1 into main Jul 4, 2024
7 checks passed
@joonashak joonashak deleted the jira-integration branch July 4, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonashak joonashak joonashak approved these changes

Assignees

@joonashak joonashak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kurukimi @joonashak