Completely rewrite Log #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeepingCreature
force-pushed
the
change/rewrite-generic
branch
2 times, most recently
from
e03ec1f
to
f55637d
Compare
Everything has been split into submodules. Log is now instantiated with a list of all supported loggers. This allows extending it without forcing virtual calls. In principle, DMD can now inline from `toString` all the way through to `write`. The intention is that you create a customized logger variable in your project.
FeepingCreature
force-pushed
the
change/rewrite-generic
branch
from
f55637d
to
f0764ba
Compare
linkrope
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Remove? We switched to GitHub actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go!!
Everything has been split into submodules.
Log is now instantiated with a list of all supported loggers. This allows extending it without forcing virtual calls. In principle, DMD can now inline from
toStringall the way through towrite. The intention is that you create a customized logger variable in your project.Best place to start is probably the README.