Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery.ui.touch-punch.js #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pperrin
Copy link

@pperrin pperrin commented Apr 1, 2014

Allow a little movement before deciding that a touch is not a click (coded to allow 5 move events - but could be a parameter).

This allows sensitive screens (like nexus10) to better register clicks - without this, it is virtually impossible for a user to 'click' as there is always slight movement between touch and release.

The downside is that 'flicking' an item to move it slightly, may register as a click also. The sensitivity could be increased (allow fewer moves between touch and release), or parameterised to make it easily for application users to adjust. Or a genuine move could be de-bounced (if a move happens, any potential click is cancelled).

Allow a little movement before deciding that a touch is not a click (coded to allow 5 move events - but could be a parameter).

This allows sensitive screens (like nexus10) to better register clicks - without this, it is virtually impossible for a user to 'click' as there is always slight movement between touch and release.

The downside is that 'flicking' an item to move it slightly, may register as a click also. The sensitivity could be increased (allow fewer moves between touch and release), or parameterised to make it easily for application users to adjust. Or a genuine move could be de-bounced (if a move happens, any potential click is cancelled).
khadorkin pushed a commit to khadorkin/jquery-ui-touch-punch that referenced this pull request Apr 19, 2014
@farin
Copy link

farin commented May 30, 2014

+1

@stuartmarsden
Copy link

Title of commit did not give it away so did not look here first. I just made my own pull request that uses the time of the touch event to determine if it is a click or not.

Not sure what is the better approach.

@pperrin
Copy link
Author

pperrin commented Jul 30, 2014

My fix works, but is nothing to write home about(!) - should really be
configurable.

Think it was my first ever pull req, on git hub - so apologies for naff
titles etc(!).
On 30 Jul 2014 16:19, "stuartmarsden" [email protected] wrote:

Title of commit did not give it away so did not look here first. I just
made my own pull request that uses the time of the touch event to determine
if it is a click or not.

Not sure what is the better approach.


Reply to this email directly or view it on GitHub
#151 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants