Added AMD support (same as in jQuery) #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much! After updating jquery-ui I began receiving the following error in responsive, even though touch-punch continued to work: "Uncaught TypeError: Cannot read property 'mouse' of undefined" This change got that annoying bugger to disappear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good job with the library! Unfortunately I am using require.js and the plugin did not work because jquery-ui was loaded in the AMD fashion. When using AMD to load touch-punch it fails since it expected a global jQuery variable to exist.
The pull request contains a wrapper function around the plugin that enables AMD support.
Because this plugin relies on jquery-ui to be loaded as well, it must be defined in an AMD loader in a way so it depends on both jquery and jquery-ui in order to properly work.