-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -centile flag #55
base: main
Are you sure you want to change the base?
Conversation
455d46c
to
813e896
Compare
I assume this is meant to address #54 in a more general way, since the median is the 50th percentile, or was this PR an independent initiative? I agree that Sort and Filter should probably be separate steps/functions, but you don't have to address it in this PR. I can do that later. Sort could also use the simpler slices.Sort (since Go 1.21) nowadays. |
The output probably needs a label, analogous to the "Average: " label for -avg. The question is if we need a short option as well. I'm not sure how people want to use it: Do they just want to look at the output on the command line or parse it for further processing in a pipeline? |
Committed a new change to have label for percentile, also include A couple other thoughts triggered but the new commit:
|
Let me know if you want me rebase to squash to single commit. |
Add this flag to show percentile.
Other thought - if gocyclo plans to support more stats features,
SortAndFilter
would be better split intoSort
andFilter
.