Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match SPDLOG_CONSTEXPR_FUNC to FMT_CONSTEXPR #2901

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Match SPDLOG_CONSTEXPR_FUNC to FMT_CONSTEXPR #2901

merged 5 commits into from
Oct 13, 2023

Commits on Oct 11, 2023

  1. Modify the condition of SPDLOG_CONSTEXPR_FUNC to match that of fmt 

    fix the issue where constexpr function in spdlog may call non-constexpr function in the bundled fmt because FMT_USE_CONSTEXPR is not defined.
    @ShujianQian @kkraus14
    ShujianQian authored and kkraus14 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b0ad647 View commit details
    Browse the repository at this point in the history

  2. add SPDLOG_HAS_FEATURE macro to avoid redefining built-in, add commen… 

    …t explaining the constexpr check
    @kkraus14
    kkraus14 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    23c69f8 View commit details
    Browse the repository at this point in the history

  3. Update implementation to reuse FMT_CONSTEXPR where possible

    @kkraus14
    kkraus14 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2421b09 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. don't need to inline, simplify to always use FMT_CONSTEXPR if it's de… 

    …fined
    @kkraus14
    kkraus14 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1897f70 View commit details
    Browse the repository at this point in the history

  2. Revert "don't need to inline, simplify to always use FMT_CONSTEXPR if… 

    … it's defined"

This reverts commit 1897f70.
    @kkraus14
    kkraus14 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fab780c View commit details
    Browse the repository at this point in the history