Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dividing a bit more exportAsTemplate #28

Merged
merged 8 commits into from
May 19, 2020
Merged

dividing a bit more exportAsTemplate #28

merged 8 commits into from
May 19, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented May 19, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          296       302    +6     
  Branches        50        50           
=========================================
+ Hits           296       302    +6     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/actions/exportAsTemplate.ts 100.00% <100.00%> (ø)
src/actions/getParameter.ts 100.00% <100.00%> (ø)
src/actions/listParameters.ts 100.00% <100.00%> (ø)
src/utils/tables.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4a040...768d1d7. Read the comment docs.

interface Input extends Actions {
groupBy?: keyof typeof GroupBy
}


export const listParameters = async ({ environment, prefix, region = REGION, ci = false, groupBy }: Input): Promise<string> => {
const normalizeGroups = (groups: Record<string, string[][]>, groupBy: keyof typeof GroupBy, ci: boolean, styles?: TableConstructorOptions['style']) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function normalizeGroups has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented May 19, 2020

Code Climate has analyzed commit 768d1d7 and detected 0 issues on this pull request.

View more on Code Climate.

@gagoar gagoar merged commit bf8ae3f into master May 19, 2020
@gagoar gagoar deleted the gg/codeClimateTake2 branch May 19, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant