Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Configuration]: fix merge configuration #33

Merged
merged 3 commits into from
May 19, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented May 19, 2020

made a silly error on the sanitization that somehow I missed in the snapshots. 🤦 🔫

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          304       306    +2     
  Branches        51        51           
=========================================
+ Hits           304       306    +2     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/utils/getGlobalOptions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb3dbe...220c3b0. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented May 19, 2020

Code Climate has analyzed commit 220c3b0 and detected 0 issues on this pull request.

View more on Code Climate.

@gagoar gagoar merged commit 44c959b into master May 19, 2020
@gagoar gagoar deleted the gg/fix_merge_configuration branch May 19, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant