Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some return types #47

Merged
merged 1 commit into from
May 28, 2020
Merged

Adding some return types #47

merged 1 commit into from
May 28, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented May 28, 2020

per #38 I had to add some return types and be more specific about callbacks in mocks.

@gagoar gagoar changed the title adding some return types Adding some return types May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          304       305    +1     
  Branches        49        49           
=========================================
+ Hits           304       305    +1     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/__tests__/helpers.ts 100.00% <100.00%> (ø)
src/utils/setAWSCredentials.ts 100.00% <100.00%> (ø)
src/utils/tables.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb5d4d...33f91e2. Read the comment docs.

@gagoar gagoar merged commit ba42406 into master May 28, 2020
@gagoar gagoar deleted the gg/someLintingAdjustments branch May 28, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant