Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for user to specify a list of interfaces to monitor #89

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

sseiler-cboe
Copy link
Contributor

These commits permit a user to specify the NICs to monitor with the default option being to monitor them all. In many cases, systems have extra interfaces that are unused and this can create false alerts that need to be configured to be ignored.

@galexrt
Copy link
Owner

galexrt commented Dec 7, 2023

@sseiler-cboe Thanks for the PR!

I will go ahead and make some changes to your branch in regard to how the nics flag is handled and how the "config" option is passed to the collectors.

I wasn't able to edit your branch directly. I have merged your changes and adjusted them. A new release will be created in the coming days.

@galexrt galexrt merged commit 32e717f into galexrt:main Dec 7, 2023
1 check passed
@galexrt
Copy link
Owner

galexrt commented Dec 7, 2023

I have released https://github.com/galexrt/dellhw_exporter/releases/tag/v1.13.1 with your PR in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants