Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider 'Not Applicable' as healthy for Nic status #95

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Consider 'Not Applicable' as healthy for Nic status #95

merged 1 commit into from
Feb 6, 2024

Conversation

B0go
Copy link
Contributor

@B0go B0go commented Feb 6, 2024 •
edited
Loading

  • Added 'Not Applicable' as an acceptable option for the fifth field
  • Wrote a new unit test to cover NIC monitoring

Test run:

=== RUN   TestNic
--- PASS: TestNic (0.00s)
PASS
ok      github.com/galexrt/dellhw_exporter/pkg/omreport 0.931s

I also run some manual tests by changing the expected values and ensuring failures in the test results.

fixes #94

@B0go
consider 'Not Applicable' as healthy for Nic status
7736351 
Signed-off-by: Victor Bogo <[email protected]>
Signed-off-by: Victor Bogo <[email protected]>
@B0go
Copy link
Contributor Author

B0go commented Feb 6, 2024

Force-pushed to fix the signature.

@galexrt galexrt merged commit ae2caff into galexrt:main Feb 6, 2024
1 check passed
@B0go B0go deleted the improve-nic-metric branch February 6, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galexrt galexrt galexrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dell_hw_nic_status metric returning 1 for functional interfaces
2 participants
@B0go @galexrt