Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plain and outlined notification's button color do not match the notification type #354

Closed
mico97 opened this issue Nov 19, 2019 · 0 comments
Closed

plain and outlined notification's button color do not match the notification type #354

mico97 opened this issue Nov 19, 2019 · 0 comments
Labels
[block] v2 notification This issue is for the notification block bug Something isn't working
Milestone
Version 2

Comments

@mico97
Copy link
Contributor

mico97 commented Nov 19, 2019

notif
@mico97 mico97 added the bug Something isn't working label Nov 19, 2019
@yssagambit yssagambit changed the title plain and outlined notification's button color do not match the notification type [notification][v2] plain and outlined notification's button color do not match the notification type Nov 19, 2019
@yssagambit yssagambit added [block] v2 notification This issue is for the notification block [version] V2 Affects version 2 only labels Nov 19, 2019
@yssagambit yssagambit added this to the Version 2 milestone Nov 19, 2019
jkapunan added a commit that referenced this issue Nov 21, 2019
@jkapunan
[block-notification] Button should match text color in plain design. C…
81659f2 
…loses #354
@jkapunan jkapunan mentioned this issue Nov 21, 2019
Merged
bfintal pushed a commit that referenced this issue Nov 21, 2019
@jkapunan @bfintal
[block-notification] Button should match text color in plain design. C…
98cee37 
…loses #354 (#402)
@bfintal bfintal added the for testing This needs to be tested for confirmation label Nov 21, 2019
@yssagambit yssagambit removed the for testing This needs to be tested for confirmation label Nov 22, 2019
@yssagambit yssagambit removed the [version] V2 Affects version 2 only label Feb 24, 2020
@yssagambit yssagambit reopened this Feb 24, 2020
@andeng1106 andeng1106 mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[block] v2 notification This issue is for the notification block bug Something isn't working
Projects
None yet
Milestone
Version 2
Development

No branches or pull requests
3 participants
@bfintal @mico97 @yssagambit