Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (accordion block): fix timeline block lines if inside accordion block #3293

Merged

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented Aug 14, 2024

fixes #3152

Copy link

github-actions bot commented Aug 14, 2024

🤖 Pull request artifacts

file commit
pr3293-stackable-3293-merge.zip e2d706c

github-actions bot added a commit that referenced this pull request Aug 14, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend not removing this, instead let's keep this but make it so that the timeline block will revert this or not inherit this value

github-actions bot added a commit that referenced this pull request Aug 19, 2024
Comment on lines 92 to 94
.stk-block-accordion__content.has-stk-block-timeline {
transform: initial;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can start using :has() since it has been now implemented in Firefox!

github-actions bot added a commit that referenced this pull request Aug 28, 2024
@bfintal bfintal merged commit 9e02f69 into develop Sep 5, 2024
@bfintal bfintal deleted the fix/3152-timeline-block-lines-inside-accordion-block branch September 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline block issue - Timeline lines glitch inside Accordion block issue
2 participants