Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{VISUAL} adds one extra line #178

Closed
janko opened this issue Nov 26, 2014 · 3 comments
Closed

{VISUAL} adds one extra line #178

janko opened this issue Nov 26, 2014 · 3 comments

Comments

@janko
Copy link

janko commented Nov 26, 2014

After trying out the fix for #177, I realized that there is one extra space being added below {VISUAL} (I think this was already before, but I forgot to report it).

Let's say I have the same snippet and code as in the above mentioned issue. I expect to end up with this:

*cursor*
  class Foo
  end
end

But instead I end up with this:

*cursor*
  class Foo
  end

end
@ajzafar
Copy link
Collaborator

ajzafar commented Nov 26, 2014

I noticed this when I was working on #177. It only happens when you use visual line select (since that includes that last newline). I considered always removing the last newline in the visual selection, but I'm not sure that's correct. If anyone has a good argument for this, please share it. In the meantime, I'm going to think about it for a bit before deciding. I'm leaning towards it though.

@ajzafar
Copy link
Collaborator

ajzafar commented Nov 27, 2014

I went ahead and did it.

@janko
Copy link
Author

janko commented Nov 27, 2014

Thank you! Yeah, I think that everyone will be using snippets from visual-line mode, so I think it really makes sense.

ajzafar added a commit that referenced this issue Jan 23, 2015
ajzafar added a commit that referenced this issue Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants