fix(gatsby-plugin-page-creator): support index routes when using the File System Route API #31339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…File System Route API
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: page creation
and removed
status: triage needed
|
This will be released as stable in 3.6.0 on 25th of May and automatically the next time |
|
Thank you @LekoArts! |
axe312ger
pushed a commit
that referenced
this pull request
May 20, 2021
…File System Route API (#31339) Co-authored-by: LekoArts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds root index URL support to the File System Route API.
Without the changes in this PR, the File System Route API behaves like the following example:
File name:
{Model.path}.jsModel:
{ "path": "/" }Resulting path:
.jsFinal URL:
/.jsWith the changes in this PR, the File System Route API behaves like the following example:
File name:
{Model.path}.jsModel:
{ "path": "/" }Resulting path:
index.jsFinal URL:
/The
index=>/transformation happens ingatsby-page-utils:gatsby/packages/gatsby-page-utils/src/create-path.ts
Line 5 in 7110189
Documentation
Existing documentation: https://www.gatsbyjs.com/docs/reference/routing/file-system-route-api/
Updates to the documentation should not be necessary since this functionality should be a natural expectation.
Related Issues
Related Discussion: #26375 (comment)