Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Life Stage field is empty #145

Closed
gbif-portal opened this issue Mar 23, 2017 · 12 comments
Closed

Life Stage field is empty #145

gbif-portal opened this issue Mar 23, 2017 · 12 comments
Assignees
Labels
api bug interpretation Interpretation issues, probably should wait to be solved in Pipelines

Comments

@gbif-portal
Copy link
Collaborator

Life Stage field is empty

Life Stage field within "Occurrence" block is empty. Old portal displays this field properly (e.g. “imago”, http://www.gbif.org/occurrence/1417496798/verbatim), new portal displays empty field (https://demo.gbif.org/occurrence/1417496798).


fbitem-occurrence1417496798

System: Chrome 56.0.2924 / Windows 10 0.0.0
Referer: https://demo.gbif.org/occurrence/1417496798
Window size: width 1298 - height 858
API log
Site log
datasetKey: b267ac9b-6516-458e-bea7-7643842187f7
publishingOrgKey: c14b9ce2-9545-4376-8a3b-6741558c256a

@MortenHofft
Copy link
Member

Both portals show it only as verbatim view. I suspect this is a case of the user not knowing the interface. But worth noticing as a potential usability issue.

@rkhalikov
Copy link

The same situation with Scientific Name Authorship field also.

@rkhalikov
Copy link

Empty fields look strange. Especially if they actually have data...

@mdoering
Copy link
Member

Looks to me like we erroneously remove LifeStage from the interpreted Occurrence. We should only remove verbatim values in case we did interpret them. If they are uninterpreted they should remain the same in both views.

Looking at the code it seems we interpret life stage, but do not flag any issue in case we fail to interpret it (like in this case). We should flag an issue and improve out life stage parser. Same for establishment means btw

@kbraak
Copy link
Contributor

kbraak commented Mar 24, 2017

Thanks @mdoering - @cgendreau I suspect these would be of interest to you. I'll leave it to you to create some new occurrence or even gbif validator issues for these interpretation issues then.

@MortenHofft
Copy link
Member

My misunderstanding of the issue them. I will reopen and label as an API task

@mdoering
Copy link
Member

should we move issues like this to the occurrence repository? We move portal issues, so we should move others too into appropriate repositories or do we lose overview with over 100 gbif repos?

One can see all issues assigned to oneself and also all open ones for any gbif repository, so I think it is better to move issue: https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+user%3Agbif+

Useful too to move issues: https://github-issue-mover.appspot.com/

@MortenHofft
Copy link
Member

i would think it made sense to move to relevant repositories - that at least is what i do with presentation related issues.

@dschigel
Copy link

dschigel commented Apr 5, 2017

Looks like an important issue to fix regarding GLOBIS-B activities

@MattBlissett
Copy link
Member

These are the things that are interpreted but don't have an issue. I've first reviewed what isn't interpreted to see what's affected.

These three can't be used in searches:

  • sex — there is so much variety in this field (20,000 verbatim values!), I'm not adding an issue. The original value is in verbatim if required.
  • establishmentMeans — I think I will leave this, as Quentin Groom is working on vocabularies etc. There are 1881 distinct unparsed values, including "Natural" on 64 million occurrences, and "wild" on about 9 million.
  • lifeStage — we have 34,102 distinct verbatim values, and we didn't have a dictionary mapping. I have added some that I'm certain about (AdultoADULT), but the rest are unassigned. Would anyone like to complete it? That should come before we add issues.

This one can be used in searches:

  • typeStatus — potentially could have an issue, but I'll leave for further discussion. There are a lot of variations on "not a type", and "voucher of", but the rest is pretty good. Should we add HYPOTYPE, PLESIOTYPE (both seem reasonable) and HOMEOTYPE (seems less reasonable) to the API, @mdoering? (Or Dmitry, and whoever actually knows about this.)

@dschigel
Copy link

on typeStatus - I am fogetting these things, the quick way to decide is to make list of what we have, and list of possible additions, and show to Donald and Thomas Pape (works in the museum, head of ICZN). I can also look it up, but by going the way I suggest you will have a choice confimred by the expert.

@mdoering
Copy link
Member

I'd be curious how much serious variety there can be in sex. If I remember correctly a lot has been "misusing" the field to do counts by sex, especially in the case of mixed observations. If the interpreted value would be a set of sexes can it be that challenging? And would it not be good to flag the cases when things are unexpected?

MattBlissett added a commit to gbif/gbif-api that referenced this issue Oct 31, 2018
@MattBlissett MattBlissett added the interpretation Interpretation issues, probably should wait to be solved in Pipelines label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug interpretation Interpretation issues, probably should wait to be solved in Pipelines
Projects
None yet
Development

No branches or pull requests

7 participants