Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #126 as initially proposed by @bbrangeo; pushing for speed (since i need it.. :) ) #127

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lucbettaieb
Copy link
Contributor

Description

Fixes #126 with changes proposed by @bbrangeo

Related Issue

Fixes #126

Example

@lucbettaieb lucbettaieb marked this pull request as ready for review February 29, 2024 13:54
@lucbettaieb lucbettaieb mentioned this pull request Feb 29, 2024
@lucbettaieb
Copy link
Contributor Author

lucbettaieb commented Feb 29, 2024

Tested locally:

Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pygbif
>>>

Also tested with my code that uses "occurrences".

@CecSve CecSve merged commit bc4d8fa into gbif:master Mar 1, 2024
5 checks passed
@lucbettaieb
Copy link
Contributor Author

Thanks @CecSve !

@airnst
Copy link

airnst commented Mar 1, 2024

Sorry to ask here, but does anyone happen to know when the update will be released to make new installations work?

@lucbettaieb
Copy link
Contributor Author

@airnst Not sure, but if you are blocked you can install from source with pip:

pip install git+https://github.com/gbif/pygbif.git@master

i think that should work...

@abubelinha
Copy link

I am not sure but I think this fix raised a new problem see #145
The specific error line was one introduced in this fix.
If I downgrade to pygbif==0.6.3 it fixes #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import name 'remove_expired_responses' from 'requests_cache'
4 participants